-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Autofix
to Fix
#7657
Rename Autofix
to Fix
#7657
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
.github/release.yml
Outdated
@@ -12,7 +12,7 @@ changelog: | |||
- title: Rules | |||
labels: | |||
- rule | |||
- autofix | |||
- fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this requires changing the label within GitHub once this merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little tricky as it seems like fix
means the change is a bug fix. Do we use the autofix
label in the changelog much anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm comfortable with this, but probably worth getting at least one more approval before moving forward. I would also be interested in Zanie's opinion as the point person on CLI and applicability and such.
I'll try to review this tomorrow morning! |
Makes sense to me, considering that we'll have "Autofix" with applicability "Manual". I defer to @zanieb for the final review |
What's the decision on what to do with the labels, should we keep them as-is? |
I don't think we need to generate a section for the |
Yeah, I think it's fine to remove from the release notes. Do we want to remove the label entirely though? I'm fine with that too. |
It kind of makes sense in the "Issue" section so seems fine to rename to |
**Summary** Mostly mechanical rename symbol, with small changes to the markdown docs to read better
e402183
to
1addc0c
Compare
Summary Mostly mechanical symbol rename and search-and-replace, with small changes to the markdown docs to read better