Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid allocating during implicit concatenated string formatting #9469

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Avoid allocating during implicit concatenated string formatting #9469

merged 1 commit into from
Jan 11, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Create a custom Iterator type to avoid collecting all string parts in AnyString::parts

Test Plan

cargo test

@MichaReiser MichaReiser added internal An internal refactor or improvement formatter Related to the formatter ci Related to internal CI tooling and removed ci Related to internal CI tooling labels Jan 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser merged commit 501bc1c into main Jan 11, 2024
17 checks passed
@MichaReiser MichaReiser deleted the parts-iter branch January 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
formatter Related to the formatter internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @charliermarsh