Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support direct references when add package #187

Merged
merged 2 commits into from
May 19, 2023
Merged

Support direct references when add package #187

merged 2 commits into from
May 19, 2023

Conversation

ischaojie
Copy link
Contributor

@ischaojie ischaojie commented May 18, 2023 •
edited
Loading

fixes #158

Test:

➜  o git:(main) ✗ rye add --git https://github.com/pallets/flask.git --branch main flask
Added flask @ git+https://github.com/pallets/flask.git@main as regular dependency

➜  o git:(main) ✗ rye add --path ../../isort-5.12.0-py3-none-any.whl isort
Added isort @ file:///Users/zhezhezhu/projects/test/o/../../isort-5.12.0-py3-none-any.whl as regular dependency

@ischaojie ischaojie marked this pull request as ready for review May 19, 2023 03:51
@mitsuhiko
Copy link
Collaborator

Thank you. This looks good!

@mitsuhiko mitsuhiko merged commit be8d3e9 into astral-sh:main May 19, 2023
@ischaojie ischaojie deleted the fix-158 branch May 20, 2023 00:00
@Porkepix Porkepix mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesChen0823 CharlesChen0823 CharlesChen0823 left review comments

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding dependencies with --git <url> fails
3 participants
@ischaojie @mitsuhiko @CharlesChen0823