Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip install --report over pip-compile #92

Closed
wants to merge 1 commit into from

Conversation

mitsuhiko
Copy link
Collaborator

@mitsuhiko mitsuhiko commented May 2, 2023

This hack uses a pip that is temporarily added to the virtualenv as an alternative over pip-compile. It does not fully address #82 but it covers some common cases.

Before merging this, some tests should be added to establish some baseline of installable packages.

Things to do before merge:

  • add tests for some common scenarios
  • restore --upgrade support for single packages

@mitsuhiko
Copy link
Collaborator Author

One significant downside of this approach over pip-tools is that the latter can resolve bad constraints. So for instance if you pin a dependency to too low version, it will manage to break that pin. pip on the other hand just bails hard

INFO: pip is looking at multiple versions of flask to determine which version is compatible with other requirements. This could take a while.
…

The conflict is caused by:
    flask 2.3.2 depends on Werkzeug>=2.3.3
    The user requested (constraint) werkzeug==2.2.0

@mitsuhiko
Copy link
Collaborator Author

I don't think that this is the path to go given the restrictions of this approach.

@mitsuhiko mitsuhiko closed this May 2, 2023
@davegaeddert
Copy link

@mitsuhiko just curious, what's the gist of the issues? Only the resolution thing you mentioned above, or more than that?

@mitsuhiko
Copy link
Collaborator Author

@davegaeddert one is the issue that it can’t resolve outdated pins, another is that it’s unclear how to upgrade single packages

@mitsuhiko mitsuhiko deleted the feature/drop-pip-compile branch May 17, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants