-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: display keyring stderr (#4343)
## Summary Closes #4162 Changes keyring subprocess to allow display of stderr. This aligns with pip's behavior since pip 23.1. ## Test Plan * Tested using gnome-keyring-backend on a self-hosted private registry as well as the keyring script described in #4162 to confirm both existing functionality and the new stderr display. * Existing tests using `scripts/packages/keyring_test_plugin` are now showing its stderr output as well.
- Loading branch information
Showing
2 changed files
with
19 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3960,6 +3960,8 @@ fn install_package_basic_auth_from_keyring() { | |
----- stdout ----- | ||
----- stderr ----- | ||
Request for public@https://pypi-proxy.fly.dev/basic-auth/simple/anyio/ | ||
Request for [email protected] | ||
Resolved 3 packages in [TIME] | ||
Downloaded 3 packages in [TIME] | ||
Installed 3 packages in [TIME] | ||
|
@@ -4005,6 +4007,8 @@ fn install_package_basic_auth_from_keyring_wrong_password() { | |
----- stdout ----- | ||
----- stderr ----- | ||
Request for public@https://pypi-proxy.fly.dev/basic-auth/simple/anyio/ | ||
Request for [email protected] | ||
error: Failed to download `anyio==4.3.0` | ||
Caused by: HTTP status client error (401 Unauthorized) for url (https://pypi-proxy.fly.dev/basic-auth/files/packages/14/fd/2f20c40b45e4fb4324834aea24bd4afdf1143390242c0b33774da0e2e34f/anyio-4.3.0-py3-none-any.whl.metadata) | ||
"### | ||
|
@@ -4044,6 +4048,8 @@ fn install_package_basic_auth_from_keyring_wrong_username() { | |
----- stdout ----- | ||
----- stderr ----- | ||
Request for public@https://pypi-proxy.fly.dev/basic-auth/simple/anyio/ | ||
Request for [email protected] | ||
error: Failed to download `anyio==4.3.0` | ||
Caused by: HTTP status client error (401 Unauthorized) for url (https://pypi-proxy.fly.dev/basic-auth/files/packages/14/fd/2f20c40b45e4fb4324834aea24bd4afdf1143390242c0b33774da0e2e34f/anyio-4.3.0-py3-none-any.whl.metadata) | ||
"### | ||
|