Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv pip install gets stuck combining --resolution=lowest-direct and --upgrade flags #1563

Closed
adamtheturtle opened this issue Feb 17, 2024 · 1 comment · Fixed by #1607
Closed

uv pip install gets stuck combining --resolution=lowest-direct and --upgrade flags #1563

adamtheturtle opened this issue Feb 17, 2024 · 1 comment · Fixed by #1607
Assignees
@charliermarsh
Labels
bug Something isn't working resolver Related to the package resolver

Comments

@adamtheturtle
Copy link
Contributor

Tested with uv 0.1.3.

Choose a package, in this example, mypy.

Run:

uv pip install --resolution=lowest-direct --upgrade "mypy"

This stalls for at least 30 minutes.

Seen on macOS (locally) and on Ubuntu (GitHub Actions).
@charliermarsh
Copy link
Member

I think you can reproduce with just: cargo run pip install --resolution=lowest-direct "wheel==0.1"

@adamtheturtle adamtheturtle mentioned this issue Feb 17, 2024
Merged
@zanieb zanieb added bug Something isn't working resolver Related to the package resolver labels Feb 17, 2024
@charliermarsh charliermarsh self-assigned this Feb 17, 2024
@charliermarsh charliermarsh mentioned this issue Feb 17, 2024
Merged
charliermarsh added a commit that referenced this issue Feb 17, 2024
@charliermarsh
Avoid propagating top-level options to sub-resolutions (#1607)
b561719 
## Summary

It's incorrect to pass the resolution and dependency mode down to the
`BuildDispatch`, since it means that we'll use `--no-deps` when building
source distributions. If you set resolution to `lowest`, it also means
we end up using (e.g.) the lowest version of `wheel`, which also doesn't
make sense.

It's fine to pass `--exclude-newer`.

Closes #1355.

Closes #1563.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working resolver Related to the package resolver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid propagating top-level options to sub-resolutions astral-sh/uv
3 participants
@adamtheturtle @charliermarsh @zanieb