-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running uv pip install 'cryptography @ .'
repeatedly doesn't rebuild, even when there are source changes
#2152
Comments
We currently only force a rebuild of local packages if there are changes to the Alternatively... we could sniff for metadata in the |
Hmm, I'm not sure Here's the output after making a change to the rust source:
|
Ah, you may need |
Yes, that works. I don't know if specifically detecting rust projects is the way to go (this is general to anything with an extension module), but something to make this behavior more ergonomic and less special-casey would be valuable. |
I agree. |
I changed the behavior such that |
Do you think there's any way to solve this with #7136? E.g., could you mark |
Hmm, maybe? I don't think the target folder is right though, it'd need to be the rust source, since you want to rebuild the target folder based on changes to the source. That said, it feels like an abstraction failure to need to have installer specific stuff for this. (Maybe that just means it should be standardized though, ugh.) |
You could probably add a |
Avoiding rebuilds has its own benefits :-)
…On Fri, Sep 6, 2024 at 5:33 PM Charlie Marsh ***@***.***> wrote:
You could probably add a build.rs script that wrote out to a file or
something, but yeah. It's mostly our fault for wanting to avoid rebuilds in
the first place.
—
Reply to this email directly, view it on GitHub
<#2152 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBCXPNYXQHNELTAZSW3ZVINSBAVCNFSM6AAAAABEFC4ATCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUHAZTSNJZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
For onlookers, we have a new API whereby you can add additional files to consider when invalidating the cache. You can also include the current Git commit (i.e., invalidate whenever the SHA changes). Looks like this: [tool.uv]
cache-keys = [{ file = "pyproject.toml" }, { file = "requirements.txt" }, { git = true }] See: https://docs.astral.sh/uv/concepts/cache/#dynamic-metadata. I don't think this will solve the extension module use-case described here, but it is helpful for things like |
We have a mixed Python+Rust codebase. Our dev process involves running
pip install .
, which I'm attempting to migrate touv pip install 'cryptography @ .'
. However, when run the second time, uv doesn't appear to actually rebuild the rust.Here's an example output:
If there's any more information I can provide, let me know!
The text was updated successfully, but these errors were encountered: