Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort dependencies before sdist in lockfile #4889

Closed
Tracked by #4893
konstin opened this issue Jul 8, 2024 · 2 comments · Fixed by #4897
Closed
Tracked by #4893

Sort dependencies before sdist in lockfile #4889

konstin opened this issue Jul 8, 2024 · 2 comments · Fixed by #4897
Assignees
@charliermarsh
Labels
enhancement New feature or improvement to existing functionality preview Experimental behavior

Comments

@konstin
Copy link
Member

konstin commented Jul 8, 2024

In the latest uv release, we split source dist and wheel entries:

[[distribution]]
name = "phonemizer"
version = "3.2.1"
source = { registry = "https://pypi.org/simple" }
sdist = { url = "https://files.pythonhosted.org/packages/2f/23/090873aa616dfaf9209dc319841204e0e85b3ff6ca6032551216e3dfe153/phonemizer-3.2.1.tar.gz", hash = "sha256:068f85f85a8a9adc638a3787aeacaf71a53e47578b12d773c097433500cd892b", size = 63146 }
dependencies = [
    { name = "attrs" },
    { name = "dlinfo" },
    { name = "joblib" },
    { name = "segments" },
    { name = "typing-extensions" },
]
wheels = [
    { url = "https://files.pythonhosted.org/packages/cb/5a/b699d5c74959c69728b44692cbacaf1035838ba5dc6aee9b8e80e60637f3/phonemizer-3.2.1-py3-none-any.whl", hash = "sha256:65eef55cd180c1f0be245f68de12bd6014a102ecce0ed8af2584fda853c75ac7", size = 90621 },
]

We should change the sorting so that sdist and wheels are last:

[[distribution]]
name = "phonemizer"
version = "3.2.1"
source = { registry = "https://pypi.org/simple" }
dependencies = [
    { name = "attrs" },
    { name = "dlinfo" },
    { name = "joblib" },
    { name = "segments" },
    { name = "typing-extensions" },
]
sdist = { url = "https://files.pythonhosted.org/packages/2f/23/090873aa616dfaf9209dc319841204e0e85b3ff6ca6032551216e3dfe153/phonemizer-3.2.1.tar.gz", hash = "sha256:068f85f85a8a9adc638a3787aeacaf71a53e47578b12d773c097433500cd892b", size = 63146 }
wheels = [
    { url = "https://files.pythonhosted.org/packages/cb/5a/b699d5c74959c69728b44692cbacaf1035838ba5dc6aee9b8e80e60637f3/phonemizer-3.2.1-py3-none-any.whl", hash = "sha256:65eef55cd180c1f0be245f68de12bd6014a102ecce0ed8af2584fda853c75ac7", size = 90621 },
]
@konstin konstin added enhancement New feature or improvement to existing functionality preview Experimental behavior labels Jul 8, 2024
@BurntSushi
Copy link
Member

Yeah, I like this.

@konstin konstin mentioned this issue Jul 8, 2024
Closed
6 tasks
@charliermarsh charliermarsh self-assigned this Jul 8, 2024
@charliermarsh
Copy link
Member

I'll do this real quick.

@charliermarsh charliermarsh mentioned this issue Jul 8, 2024
Merged
charliermarsh added a commit that referenced this issue Jul 8, 2024
@charliermarsh
Sort dependencies before wheels and source distributions (#4897)
71c6a9f 
Closes #4889.
@konstin konstin moved this to Backlog in uv: release-ready Jul 9, 2024
@konstin konstin moved this from Backlog to Done in uv: release-ready Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
enhancement New feature or improvement to existing functionality preview Experimental behavior
Projects
No open projects
uv: release-ready
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort dependencies before wheels and source distributions astral-sh/uv
3 participants
@BurntSushi @charliermarsh @konstin