Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--config-file pyproject.toml silently fails #5832

Closed
charliermarsh opened this issue Aug 6, 2024 · 0 comments · Fixed by #5842
Closed

--config-file pyproject.toml silently fails #5832

charliermarsh opened this issue Aug 6, 2024 · 0 comments · Fixed by #5842
Assignees
@charliermarsh
Labels
bug Something isn't working configuration Settings and such

Comments

@charliermarsh
Copy link
Member

Because we're very relaxed in how we parse the configuration, pyproject.toml adheres to the uv.toml schema (since all fields are optional). But this doesn't do what the user expects.
@charliermarsh charliermarsh self-assigned this Aug 6, 2024
@charliermarsh charliermarsh added bug Something isn't working configuration Settings and such labels Aug 6, 2024
@charliermarsh charliermarsh mentioned this issue Aug 6, 2024
Merged
charliermarsh added a commit that referenced this issue Aug 6, 2024
@charliermarsh
Reject pyproject.toml in --config-file (#5842)
9b06b39 
This already rejects `pyproject.toml`... but because the schema
validation is relaxed (we allow unknown fields, and all fields are
optional), a `pyproject.toml` doesn't get properly rejected here.

This PR makes the schema stricter, but in a safe way (by adding the
other `tool.uv` fields, like `workspace`, as any).

Closes #5832.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working configuration Settings and such
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject pyproject.toml in --config-file astral-sh/uv
1 participant
@charliermarsh