-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn --verify-hashes
on by default
#9164
Labels
Comments
Note pip compatibility isn't really an argument here, since in the above example pip will automatically infer
|
Yeah I think |
I think it's fine for this to go out in a patch release, personally. |
(PR welcome or I'll get to it in the near future ofc.) |
hauntsaninja
added a commit
to hauntsaninja/uv
that referenced
this issue
Nov 17, 2024
hauntsaninja
added a commit
to hauntsaninja/uv
that referenced
this issue
Nov 17, 2024
charliermarsh
added a commit
that referenced
this issue
Nov 18, 2024
Fixes #9164 Using clap's `default_value_t` makes the `flag` function unhappy, so just set the default when we unwrap. Tested with no flags, `--verify-hashes`, `--no-verify-hashes` and setting in uv.toml --------- Co-authored-by: Charlie Marsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This would technically be a breaking change, so might need to wait for uv 0.6 (although "I have a hash but I expect it to not be checked" seems pretty niche). It's surprising to me that hashes are ignored by default and it's bad to have security related surprises
See also #3305
The text was updated successfully, but these errors were encountered: