Improve error messaging when a dependency is not found #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/package-not-found
branch
2 times, most recently
from
2f90628 to
785c9e7
Compare
zanieb
force-pushed
the
zb/package-not-found
branch
from
785c9e7 to
915bd38
Compare
|
I expect this to require some refactoring and polish, but it's ready for review. |
| ); | ||
| return Ok(Dependencies::Unavailable( | ||
| "The package is unavailable".to_string(), | ||
| )); |
There was a problem hiding this comment.
This should never happen, right?
There was a problem hiding this comment.
(Wondering if the whole thing should be a debug assert so that we don't have to do this extra hash lookup in release, but what you have here is probably better, it's negligible.)
There was a problem hiding this comment.
Yeah this should never happen. I am just hesitant to panic in production.
charliermarsh
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, whenever we encountered a missing package we would throw an error without information about why the package was requested. This meant that if a transitive dependency required a missing package, the user would have no idea why it was even selected. Here, we track
NotFoundandNoIndexerrors asNoVersionsincompatibilities with an attached reason. Improves our test coverage for--no-indexwithout--find-links.The snapshots show a nice improvement.
I think this will also enable backtracking to another version if some version of transitive dependency has a missing dependency. I'll write a scenario for that next.
Requires astral-sh/pubgrub#22