Read Python version files during toolchain installs #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-install-many
branch
from
7d30506 to
ab7d5ae
Compare
zanieb
force-pushed
the
zb/toolchain-install-python-version
branch
from
de96671 to
6773f5e
Compare
zanieb
added
the
enhancement
zanieb
commented
Jun 15, 2024
zanieb
force-pushed
the
zb/toolchain-install-python-version
branch
from
6773f5e to
411611e
Compare
|
I think we should also allow defining them in the toml configuration, something like |
konstin
approved these changes
Jun 17, 2024
zanieb
force-pushed
the
zb/toolchain-install-many
branch
3 times, most recently
from
677b392 to
278c5c0
Compare
zanieb
force-pushed
the
zb/toolchain-install-python-version
branch
from
411611e to
6c7ba3c
Compare
zanieb
force-pushed
the
zb/toolchain-install-many
branch
from
278c5c0 to
af9eeb1
Compare
zanieb
force-pushed
the
zb/toolchain-install-python-version
branch
from
6c7ba3c to
fd09f43
Compare
BurntSushi
approved these changes
Jun 17, 2024
ibraheemdev
approved these changes
Jun 17, 2024
zanieb
force-pushed
the
zb/toolchain-install-many
branch
from
af9eeb1 to
25427db
Compare
zanieb
force-pushed
the
zb/toolchain-install-python-version
branch
from
fd09f43 to
3bc3227
Compare
Tracking in #4359 |
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
Adds support for reading Python version files (introduced in #4335) to `uv venv`. If present, we'll use the file version as the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bare
uv toolchain installinvocation now reads default requests from Python version files in the working directory. In order, a bare invocation means:.python-versions.python-versionThis replaces all the functionality of
cargo dev fetch-python, which we drop in #4337