More precise locking with --prefix option #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added
the
enhancement
zanieb
approved these changes
Jun 25, 2024
ericmarkmartin
force-pushed
the
precise-prefix-locking
branch
from
3234fd6 to
716cc0c
Compare
|
Thanks! Oversight on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #4085, support was implemented for the
--prefixoption. When using this option, however, a lock is either acquired on the virtualenv or globally, preventing multiple installs to different--prefixs from the same interpreter.In this change, acquire the lock on just the prefix in question.
Test Plan
Ran a
uv pip installwith--prefixandRUST_LOG=traceand observed that the lock was acquired in the prefix.