Include URLs on graph edges #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/edge
branch
from
3e75470 to
cd31e03
Compare
|
This failure is on main already, so gonna merge. |
|
Wait, nevermind, there's a separate Windows failure. |
charliermarsh
force-pushed
the
charlie/edge
branch
from
cd31e03 to
24c2009
Compare
charliermarsh
force-pushed
the
charlie/edge
branch
from
24c2009 to
77463b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Excellent find from @konstin. If we have a package that's included in two forks at the same version, but with different URLs, we need to avoid collapsing them in the lockfile.
Closes #5294.