-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add help sections for global options #5665
Conversation
Currently with proposed:
@zanieb Do we have any expected output or a specific order? |
Hm are those other ones not global options too? Ordering within the group seems okay to leave as-is for now. I think I want to group everything e.g. a "Resolver options" section then deal with within-group ordering afterwards if needed. |
They are, but I'm not sure if we want e.g.
So, do you want a dedicated heading for each separate flatten command? |
Fair, but
Not quite. Like... we don't want a "Resolver installer options" group or a "Refresh options" group, instead we want "Resolver options", "Installer options", and "Cache options" groups :) I was planning on looking at every option and figuring out categories. If you're interested in it, you're definitely welcome to and I can help. |
I'll how to make this work later. Another question, If we use |
Okay, then I suppose we could separate this part into follow-up PRs and focus this PR solely on the global options. |
I don't think so (without trying it) |
Back :) Are these what you expected?
(Maybe placing |
Yeah that's roughly what I'd expect. Annoying the indentation isn't the same, I wonder if that'll be a problem. |
We probably want to have a |
Could you show me about this part you are refering to? |
e.g. "Avoid reading from or writing to the cache" is not at the same level as "Print version" |
Got it, but I currently don't know how to handle it. |
Yeah let's deal with that separately haha seems hard |
Rebased and updated the snapshots. You should be able to see the changes in the snapshots now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
GlobalArgs
to dedicated heading
Summary
Part of #4454 .
Test Plan
test cases included.