Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra labels and annotations to task pods #79

Closed

Conversation

juniorz
Copy link

@juniorz juniorz commented May 7, 2020

It is common to the k8s ecosystem having add-ons that are configurable based on pod's annotations/labels (for example, Istio sidecar injection and Vault secrets injection).

This PR makes it possible for pods spun up using KubernetesExecutor or KubernetesPodOperator to better integrate with such add-ons.

@juniorz
Copy link
Author

juniorz commented May 7, 2020

cc/ @dimberman

@juniorz
Copy link
Author

juniorz commented May 12, 2020

@morhook , thank you for reviewing this PR!
Let me know if there's anything missing from my side to get this merged.

@schnie
Copy link
Member

schnie commented May 13, 2020

Hey @juniorz thanks for the PR! I'd be happy to merge this right in, but we have a larger PR in the works that actually removes this file entirely from the default configuration (along with a lot of other things).

This is in an effort to make this chart more agnostic and generally usable outside of Astronomer. That work is being down over on this PR #66. A similar draft PR is open on the apache/airflow repo to add this as the official chart - apache/airflow#8777.

I think we may have discussed this file in particular in the PR, but we decided to make it empty by default and just have an example commented out that folks could copy / paste for an example. I think use-cases of this pod mutation hook are very different from org to org so it made sense to just give full control to users.

Interested to hear what you think about this.

@juniorz
Copy link
Author

juniorz commented May 13, 2020

@schnie , thanks for the prompt feedback!

I believe we will just keep defining our own "mutation hook" (via scheduler.airflowLocalSettings), and re-evaluate where to go once the new version is released.

@juniorz juniorz closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants