Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix where we place the sql cli include directory #1440

Closed
tatiana opened this issue Dec 16, 2022 · 0 comments · Fixed by #1560
Closed

Fix where we place the sql cli include directory #1440

tatiana opened this issue Dec 16, 2022 · 0 comments · Fixed by #1560
Assignees
Labels
bug Something isn't working product/sql-cli
Milestone

Comments

@tatiana
Copy link
Collaborator

tatiana commented Dec 16, 2022

Describe the bug
When installing the SQL CLI python library, it's incorrectly adding the include directory in the root of the site-packages.

Version

  • SQL CLI: 0.2.2

To Reproduce


$ python3 -mvenv venv
$ source venv/bin/activate
$ pip install astro-sql-cli
$ tree venv/lib/python3.8/site-packages/include/
venv/lib/python3.8/site-packages/include/
└── base
    ├── config
    │   ├── default
    │   │   └── configuration.yml
    │   ├── dev
    │   │   └── configuration.yml
    │   └── global
    │       └── configuration.yml
    ├── data
    │   ├── imdb.db
    │   └── retail.db
    └── workflows
        ├── example_basic_transform
        │   └── top_animations.sql
        ├── example_load_file
        │   ├── load_imdb_movies.yaml
        │   └── transform_imdb_movies.sql
        └── example_templating
            ├── filtered_orders.sql
            └── joint_orders_customers.sql

Expected behaviour

The include directory It should be inside the sql_cli package:

venv/lib/python3.8/site-packages/sql_cli/
@tatiana tatiana added bug Something isn't working product/sql-cli labels Dec 16, 2022
@tatiana tatiana added this to the sql-cli/0.3.0 milestone Dec 16, 2022
@feluelle feluelle self-assigned this Jan 9, 2023
feluelle added a commit that referenced this issue Jan 10, 2023
# Description

## What is the current behavior?

See the referenced issue for details.

closes: #1440 

## What is the new behavior?

After reading python-poetry/poetry#2015, it
seems the best solution is to include the "include" directory directly
in the project.

## Does this introduce a breaking change?

No.

### Checklist
- [x] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
utkarsharma2 pushed a commit that referenced this issue Jan 17, 2023
# Description

## What is the current behavior?

See the referenced issue for details.

closes: #1440 

## What is the new behavior?

After reading python-poetry/poetry#2015, it
seems the best solution is to include the "include" directory directly
in the project.

## Does this introduce a breaking change?

No.

### Checklist
- [x] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product/sql-cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants