Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SQLite adapters tests #1341

Closed
pankajastro opened this issue Nov 26, 2024 · 3 comments · Fixed by #1366
Closed

Enable SQLite adapters tests #1341

pankajastro opened this issue Nov 26, 2024 · 3 comments · Fixed by #1366
Assignees
Labels
area:testing Related to testing, like unit tests, integration tests, etc
Milestone

Comments

@pankajastro
Copy link
Contributor

We are running the SQLite adapters tests for dbt-core 1.4, but these tests have recently started failing. The SQLite adapters have since added support for dbt-core 1.5, so I attempted an upgrade, but that also failed and requires further investigation. There are existing issues in the repository related to upgrading the SQLite adapters to various dbt-core versions, some of which have been open for over a year:

Additionally, there is an open issue calling for a maintainer for the project: codeforkjeff/dbt-sqlite#48

It's also worth noting that dbt-core 1.4 and 1.5 have reached their End of Life (EOL), as outlined here: https://docs.getdbt.com/docs/dbt-versions/core#latest-releases.

The goal of this ticket is to restore the SQLite adapter tests.

@dosubot dosubot bot added the area:testing Related to testing, like unit tests, integration tests, etc label Nov 26, 2024
@tatiana
Copy link
Collaborator

tatiana commented Nov 26, 2024

The idea with the sqlite adaptor tests was to have a cheap alternative to the Postgres ones. Perhaps we can look into adopting a not so cheap alternative, BQ, or another one - WDYT?

@pankajastro
Copy link
Contributor Author

BQ option looks good to me, and I believe we already have the credentials set up in CI for this

pankajastro added a commit that referenced this issue Nov 26, 2024
…re Clone Test to Pass CI (#1337)

closes: #1335

- Disabled "Run-Integration-Tests-Sqlite" Job and created issue
#1341 to enable it
- Installed `eval_type_backport` in tests and created an issue
#1342 to remove it
- pin dbt version dbt-core<1.8.9 created issue to unpin it
#1343
- pin dbt version for Kubernetes tests and create issue to unpin it
#1344

CI success:
https://github.com/astronomer/astronomer-cosmos/actions/runs/12026097151/job/33524412817?pr=1337
@phanikumv phanikumv added this to the Cosmos 1.8.0 milestone Dec 3, 2024
@pankajastro
Copy link
Contributor Author

@tatiana, @phanikumv and I agreed to use PostgreSQL for this test

pankajastro added a commit that referenced this issue Dec 10, 2024
closes: #1341

previously ran SQLite tests with dbt-core version 1.4, which has reached
its end of life. Recently, these tests have started failing. Since we
rely on the repo: https://github.com/codeforkjeff/dbt-sqlite/ for
running the tests, and it is no longer actively maintained, this PR
performs the necessary cleanup to address the issue

- Point the sqlite test to use Postgres
- Remove CI workflow job: Run-Integration-Tests-Sqlite
- Remove hatch target: hatch run
tests.py3.12-2.10:test-integration-sqlite-setup and hatch run
tests.py3.12-2.10:test-integration-sqlite
- Remove pytest marker `sqlite`
- Remove dbt project simple
- Update manifest file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:testing Related to testing, like unit tests, integration tests, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants