-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actionlint #1243
Add actionlint #1243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not understand exactly on what are we checking with actionlint here. Can you please help me understand?
yamls inside |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 90 90
Lines 5389 5389
=======================================
Hits 5313 5313
Misses 76 76 ☔ View full report in Codecov by Sentry. |
and what do we check for exactly in those yamls? |
Is it that we have the template yaml that we use and it will report for missing secrets that need to be passed from other yamls that use the template YAML? |
Including but not limited to this check, the check you mentioned is https://github.com/rhysd/actionlint/blob/main/docs/checks.md#check-inputs-and-secrets-in-workflow-call, but it can also check a bunch of potential failures |
Failures due to #1240 changes (fixed in #1242) can be detected through actionlint. Thus, adding this lint for preventing this kind of error in the future