Compare beginning and end of whole PR when determining if dag-only #53
Conversation
Co-Authored-By: Chris Abella <[email protected]>
action.yaml
Outdated
| @@ -264,7 +264,7 @@ runs: | |||
| - name: Get Deployment Type | |||
| run: | | |||
| cd ${{ inputs.root-folder }} | |||
| files=$(git diff --name-only HEAD^..HEAD) | |||
| files=$(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep '^deployments/' | awk -F/ '{print $2}' | sort -u) | |||
There was a problem hiding this comment.
What is the purpose of the grep/awk/sort?
There was a problem hiding this comment.
There wasn't, removed now
Co-Authored-By: Chris Abella <[email protected]>
| @@ -264,7 +264,7 @@ runs: | |||
| - name: Get Deployment Type | |||
| run: | | |||
| cd ${{ inputs.root-folder }} | |||
| files=$(git diff --name-only HEAD^..HEAD) | |||
| files=$(git diff --name-only ${{ github.event.before }} ${{ github.event.after }}) | |||
There was a problem hiding this comment.
I am not sure if this will work with this change alone, because the clone on line 90 only fetches with a depth of two commits. Some options may be to fetch a reasonably large number of commits, say 50, which leaves a small risk of missing some in extreme cases, or to fetch all commits (I think the default if you don't specify fetch-depth, would need to be check that) which could be slow on very large repos, or to somehow use the push event payload to figure out the required fetch depth for that push (not sure if this is possible, but it would be the length of the commits list + 1).
There was a problem hiding this comment.
Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags. Refer here to learn which commit $GITHUB_SHA points to for different events.
There was a problem hiding this comment.
Could we just run git fetch origin ${{ github.event.before }} after checkout?
| - name: Fetch commit from before PR | ||
| run: | | ||
| get fetch origin ${{ github.event.before }} | ||
| shell: bash |
There was a problem hiding this comment.
This is probably not needed as you are not using any bash directives
|
can't really make a pre-release from the this branch so I'll have to merge and make a pre-release off main |
Based on @cdabella's demo, swapping comparison of only the most recent commit for a comparison of the whole PR.
Closes #52