Add support for submodule cloning during checkout #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremybeard
reviewed
Sep 3, 2024
action.yaml
Outdated
| @@ -82,6 +82,10 @@ inputs: | |||
| build-secrets: | |||
| required: false | |||
| description: "Mimics docker build --secret flag. See https://docs.docker.com/build/building/secrets/ for more information. Example input 'id=mysecret,src=secrets.txt'" | |||
| submodule: | |||
There was a problem hiding this comment.
How about checkout-submodules so its more clearly about the checkout and that you could have multiple?
There was a problem hiding this comment.
updated to checkout-submodule, also ran through some manual tests to ensure it's functioning as per expectation
jeremybeard
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
submoduleto allow cloning the repo including submodules. Possible values aretrue,false(default), andrecursive. Works only whencheckoutis set to true. SSH URLs beginning with[email protected]:are converted to HTTPS.Closes: #76
Testing: