Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_query_payload should return the sql/tap query when available #2129

Closed
bsipocz opened this issue Aug 5, 2021 · 1 comment · Fixed by #2588
Closed

get_query_payload should return the sql/tap query when available #2129

bsipocz opened this issue Aug 5, 2021 · 1 comment · Fixed by #2588

Comments

@bsipocz
Copy link
Member

bsipocz commented Aug 5, 2021

I feel it would be more useful to have the sql/tap query returned with get_query_payload kwarg rather than the input dictionary when available. The logic with the kwarg is to provide a convenient way to debug problematic queries and it should return whatever is sent to the server.

E.g. instead of {'table': 'kelttimeseries', 'format': 'ipac'} I would like to get "select * from kelttimeseries where kelt_sourceid='KELT_N02_lc_012738_V01_east' kelt_field N02" that is more appropriate to plug into the web interface.

I've run into this with the nasa_exoplanet_archive module, but it's possible that other modules do the same, too.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 16, 2022

All modules have been checked and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant