Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to actions #1925

Merged
merged 14 commits into from
Jan 12, 2021
Merged

Switch CI to actions #1925

merged 14 commits into from
Jan 12, 2021

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jan 5, 2021

Bare minimum PR to kick-off some CI runs:

  • minimalist changes to the packaging so tox is able to run
  • build_docs is totally messed up locally, I run into an error, even thogh I have a recent pyvo installed. It all worked before I hacked the packaging, but atm have no time to investigate. It's very similar to automodapi crashing with sphinx 3.1.1 sphinx-automodapi#108, but I couldn't identify which dependency is missing. This is now gone
Extension error:
Handler <function process_automodsumm_generation at 0x1198247a0> for event 'builder-inited' threw an exception (exception: module 'pyvo' has no attribute 'dal')
  • somehow I don't get the test output real time, it only shows up then the step is done, both on GH and also locally. Any ideas?
  • remote data tests are currently ignored, those should probably go into a separate file that runs on merges, as well as for cron.

Overall, there is a ton left to do, but we should aim to modify it until we get something and then do a proper follow-up.

cc @pllim

@bsipocz
Copy link
Member Author

bsipocz commented Jan 5, 2021

Test are running here: https://github.com/bsipocz/astroquery/actions/

@bsipocz
Copy link
Member Author

bsipocz commented Jan 5, 2021

@pllim - do you have any tips why the -W for the docs build is not failing the test run? There are 17 docs warnings, all from the PRs that got merged when we didn't have any CI running (I think we shouldn't have merged anything, it's always more trouble fixing things in master rather than in the PRs.)

@bsipocz
Copy link
Member Author

bsipocz commented Jan 5, 2021

Also @embray and @pllim -does this config path issue rings a bell for you? I saw some possible related stuff recently in core, but you're much more in the loop atm. https://github.com/bsipocz/astroquery/runs/1649021383?check_suite_focus=true
We only run into it in oldest dependency test, which is atm astropy 3.1. I think we are totally open to the idea of bumping the min requirement to LTS if you don't have another quick solution.

@pllim

This comment has been minimized.

description = run tests

deps =
devastropy: git+https://github.com/astropy/astropy.git#egg=astropy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the job with devastropy is also building pyregion from source.

 ERROR: Failed building wheel for pyregion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!!! It is a Python 3.9 job. Perhaps pyregion doesn't have wheel for it.

Copy link
Member Author

@bsipocz bsipocz Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I asked about it in the regions channel. Actually I would prefer to not have it installed than using py3.8 here. Do you know a trick of how to remove a dependency from the all list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know a trick of how to remove a dependency from the all list?

Unfortunately, I don't. The only options I know of are either refactoring the listing in setup.cfg or manually state your dependencies in tox.ini.

tox.ini Show resolved Hide resolved
@pllim
Copy link
Member

pllim commented Jan 5, 2021

somehow I don't get the test output real time,

Depends on GitHub Actions buffering, I am guessing. I don't think it is within our control. Unless I misunderstood?

build_docs -W

I see you are still using python setup.py build_sphinx -W, which is no longer supported after APE 17. I would recommend deferring to APE 17 transition to fix, or use RTD PR builder with the option to turn warning into failure.

tox.ini Outdated Show resolved Hide resolved
@bsipocz
Copy link
Member Author

bsipocz commented Jan 12, 2021

Oldest astropy needed to be bumped to 3.1.2, but with that everything seems to work. One more rebase, and if this keep passing, I'm merging it.

I'm opening an issue for the still outstanding stuff.

@bsipocz
Copy link
Member Author

bsipocz commented Jan 12, 2021

And the end I also needed to remove aplpy as well as pyregion from the dependencies for py39 as the former relies on shapely that doesn't build.

@bsipocz bsipocz merged commit 9915fac into astropy:master Jan 12, 2021
@bsipocz
Copy link
Member Author

bsipocz commented Jan 12, 2021

We have CI yet again! 🎉

@pllim
Copy link
Member

pllim commented Jan 12, 2021

Re: skipping CI (saw your reply in email but cannot find it here no more) -- Yes, you are welcome to use https://github.com/pllim/action-skip-ci/ . I deployed it in several of my projects and it works for me. For example: https://github.com/spacetelescope/synphot_refactor/blob/master/.github/workflows/ci_workflows.yml

@bsipocz
Copy link
Member Author

bsipocz commented Jan 12, 2021

Yes, it's in the collapsed conversation above, I've noticed that the links in emails/notifications not always work properly :(

@pllim pllim mentioned this pull request Jan 12, 2021
eerovaher added a commit to eerovaher/astroquery that referenced this pull request Sep 23, 2021
The module `astroquery.utils.decorators` imported two decorators used
for deprecating from `astropy`, but also constructed the decorators if
the installed `astropy` version was too old to have them. The module has
become obsolete because the minimum required `astropy` version for
`astroquery` was updated in astropy#1925, and the decorators can now always be
imported directly from `astropy`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants