-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CI to actions #1925
Switch CI to actions #1925
Conversation
Test are running here: https://github.com/bsipocz/astroquery/actions/ |
@pllim - do you have any tips why the |
Also @embray and @pllim -does this config path issue rings a bell for you? I saw some possible related stuff recently in core, but you're much more in the loop atm. https://github.com/bsipocz/astroquery/runs/1649021383?check_suite_focus=true |
This comment has been minimized.
This comment has been minimized.
description = run tests | ||
|
||
deps = | ||
devastropy: git+https://github.com/astropy/astropy.git#egg=astropy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why the job with devastropy is also building pyregion from source.
ERROR: Failed building wheel for pyregion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah!!! It is a Python 3.9 job. Perhaps pyregion doesn't have wheel for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I asked about it in the regions channel. Actually I would prefer to not have it installed than using py3.8 here. Do you know a trick of how to remove a dependency from the all list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know a trick of how to remove a dependency from the all list?
Unfortunately, I don't. The only options I know of are either refactoring the listing in setup.cfg
or manually state your dependencies in tox.ini
.
Depends on GitHub Actions buffering, I am guessing. I don't think it is within our control. Unless I misunderstood?
I see you are still using |
Co-authored-by: P. L. Lim <[email protected]>
…ls features from 3.1.2
Oldest astropy needed to be bumped to 3.1.2, but with that everything seems to work. One more rebase, and if this keep passing, I'm merging it. I'm opening an issue for the still outstanding stuff. |
d3150f5
to
7cbac80
Compare
And the end I also needed to remove aplpy as well as pyregion from the dependencies for py39 as the former relies on shapely that doesn't build. |
We have CI yet again! 🎉 |
Re: skipping CI (saw your reply in email but cannot find it here no more) -- Yes, you are welcome to use https://github.com/pllim/action-skip-ci/ . I deployed it in several of my projects and it works for me. For example: https://github.com/spacetelescope/synphot_refactor/blob/master/.github/workflows/ci_workflows.yml |
Yes, it's in the collapsed conversation above, I've noticed that the links in emails/notifications not always work properly :( |
The module `astroquery.utils.decorators` imported two decorators used for deprecating from `astropy`, but also constructed the decorators if the installed `astropy` version was too old to have them. The module has become obsolete because the minimum required `astropy` version for `astroquery` was updated in astropy#1925, and the decorators can now always be imported directly from `astropy`.
Bare minimum PR to kick-off some CI runs:
build_docs is totally messed up locally, I run into an error, even thogh I have a recent pyvo installed. It all worked before I hacked the packaging, but atm have no time to investigate. It's very similar to automodapi crashing with sphinx 3.1.1 sphinx-automodapi#108, but I couldn't identify which dependency is missing.This is now goneOverall, there is a ton left to do, but we should aim to modify it until we get something and then do a proper follow-up.
cc @pllim