Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make XMatch prepare tables error message state the two possible causes for failure #3168

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

ManonMarchand
Copy link
Member

Fixes #1464

This PR modifies the error message to reflect the two possible causes for failure:

  • either the table does not exist in the XMatch server (typo in the table name, or this VizieR table has no coordinates, and thus cannot be cross matched)
  • or the user needs to provide colRa and colDec (the only info that was given before)

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (fbf55b0) to head (e447461).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
+ Coverage   67.49%   67.68%   +0.18%     
==========================================
  Files         232      229       -3     
  Lines       18446    18365      -81     
==========================================
- Hits        12450    12430      -20     
+ Misses       5996     5935      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

either the catalog is not available (no coordinates or typo in the name) or the user has to specify colRa and colDec
@ManonMarchand ManonMarchand force-pushed the xmatch-two-vizier-tables branch from fcbaff0 to e447461 Compare January 7, 2025 11:27
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

astroquery/xmatch/core.py Outdated Show resolved Hide resolved
@bsipocz bsipocz merged commit 49103b7 into astropy:main Jan 7, 2025
1 check was pending
@bsipocz bsipocz added this to the v0.4.8 milestone Jan 7, 2025
@ManonMarchand ManonMarchand deleted the xmatch-two-vizier-tables branch January 8, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: XMatch two Vizier catalogs then no col refs should be added
2 participants