-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with Numpy 2.0, remove setup.cfg and more #85
Conversation
|
||
include_dirs = [np.get_include(), UTIL_DIR] | ||
libraries = [] | ||
|
||
if 'CFLAGS' in os.environ: | ||
extra_compile_args = os.environ['CFLAGS'].split() | ||
else: | ||
extra_compile_args = ['-g', '-O3', '-funroll-loops', '-ffast-math'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmccully - Not sure if we should have those flags by default, especially -ffast-math
which is an option that people should use carefully (https://simonbyrne.github.io/notes/fastmath/)
|
@cmccully - PR is ready, do you want to have a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - I think we should also switch to the OpenAstronomy wheel building workflow but I'm happy to do that in a follow-up PR.
As this is mainly infrastructural, I think we should go ahead and merge so that other packages can work properly with Numpy 2.0. However, I don't have permission to merge, so need to find someone who does. |
@astrofrog , I updated the team, you should be able to merge now. |
@cmccully - with Numpy 2.0 coming soon we will need to publish new wheels built with Numpy 2.0 (so they will be compatible with both Numpy 1.x and 2.0).
Also did various infrastructure updates to get rid of warnings etc.