Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New offset_by with new API #140

Merged
merged 2 commits into from
Jul 2, 2021
Merged

New offset_by with new API #140

merged 2 commits into from
Jul 2, 2021

Conversation

pllim
Copy link
Member

@pllim pllim commented Jul 1, 2021

Fix #139

  • New offset_by with new API
  • Deprecate offset_to with old API.
  • Added tests and updated example notebook.
  • Bonus: Fixed a test that was writing file into source dir.

Deprecate offset_to with old API.

Added tests and updated example notebook.

Fixed a test that was writing file into source dir.
@pllim pllim added this to the 0.3 milestone Jul 1, 2021
@pllim pllim requested review from eteq and mwcraig July 1, 2021 20:50
Copy link
Member

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pllim, merging!

@mwcraig mwcraig merged commit c594308 into astropy:main Jul 2, 2021
@pllim pllim deleted the rename-offset-by branch July 2, 2021 18:46
@mwcraig mwcraig mentioned this pull request Jul 2, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename offset_to to offset_byand have it use units
2 participants