Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require numpy<2 and new cron workflow #1083

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Conversation

aphearin
Copy link
Contributor

Add new cron workflow that runs CI tests as a cron job every month

@aphearin
Copy link
Contributor Author

This PR brings in a new cron workflow that will run in the background every month. Our CI currently fails for some reason due entirely to workflow config, and so #1082 can now be merged even though it is failing.

@aphearin
Copy link
Contributor Author

As reported in #1082, the halotools CI now fails in a way that is resolved by only running tests with numpy==1.26.4. The last two commits of this PR (d82cdc5 and a5b0b59) attempt to modify our CI so that numpy<2 is used, but these attempts did not succeed at creating the correct environment, because the following message still appears in the test report:

------------------------------- Captured stderr --------------------------------
A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.1.0 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

@johannesulf when you said you ran tests successfully with numpy==1.26.4, were you referring to your local installation? Or tests run through CI on github?

@aphearin
Copy link
Contributor Author

Hey nvm @johannesulf, I was just adding numpy<2 to the wrong place to communicate with tox. It was super helpful that you identified the root source of the failure was future compatibility with numpy - thanks again!

@aphearin
Copy link
Contributor Author

Besides bringing in a new cron workflow, this PR resolves the workflow failures that prevented CI from running on #1082. The resolution was to change install requirements to numpy<2. It's not clear whether this is a compatibility issue between halotools source code and numpy>=2, or some incompatibility elsewhere in our dependency chain that will resolve in time.

@aphearin aphearin merged commit b73e5a7 into astropy:master Aug 27, 2024
5 checks passed
@aphearin aphearin deleted the ci_cron branch August 27, 2024 23:21
@aphearin aphearin changed the title Add new cron workflow Require numpy<2 and new cron workflow Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant