Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More verbose 'download' text on website tutorial pages #20

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

jeffjennings
Copy link
Contributor

Replaces 'Download' with 'Download this notebook'

@adrn
Copy link
Member

adrn commented Oct 30, 2024

Nice, yes this would be good! Can you assess if the failing test is critical to fix now or can wait?

Copy link
Member

@adrn adrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I see the fix - good!

@jeffjennings
Copy link
Contributor Author

thanks for the rapid review. Would you mind merging (I can't)?

@adrn adrn merged commit ffa9c8b into astropy:main Oct 30, 2024
5 checks passed
@jeffjennings jeffjennings deleted the download_text branch October 30, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants