Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxcar extraction with non-finite pixels #245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hpparvi
Copy link
Contributor

@hpparvi hpparvi commented Jan 29, 2025

This PR adds a new exclude mask treatment option to BoxcarExtract, allowing the extraction to exclude any non-finite pixels. With the exclude option, the extraction is now carried out as a weighted sum, calculated as the average of the finite in-window pixels multiplied by the number of in-window pixels. The behaviour stays identical to the previous with the other mask treatment options or if no non-finite values are present.

@hpparvi hpparvi self-assigned this Jan 29, 2025
@hpparvi hpparvi added this to the v1.5 milestone Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (e0ac82a) to head (9713654).

Files with missing lines Patch % Lines
specreduce/extract.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   85.38%   85.44%   +0.06%     
==========================================
  Files          13       13              
  Lines        1177     1182       +5     
==========================================
+ Hits         1005     1010       +5     
  Misses        172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hpparvi hpparvi changed the title Weighted boxcar extraction Boxcar extraction with non-finite pixels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant