Fix flake8 lint error in our repo #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhitingHu
approved these changes
Oct 22, 2019
| @@ -11,6 +11,7 @@ | |||
| import regex as re | |||
| from functools import lru_cache | |||
|
|
|||
|
|
|||
| @lru_cache() | |||
| def bytes_to_unicode(): | |||
There was a problem hiding this comment.
Have the functions in this file been included in the GPT2 tokenizer etc as in Texar-PyTorch? So that we can get rid of this file?
There was a problem hiding this comment.
Yes. After this one is merged, I will refactor #228 and merge it at first and then polish GPT2 example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.flake8file.travis.ymlto get rid of a huge amount of error messagesflake8lint errors in bothtexarandexamples