Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stdin.rs comments to say "read" instead of "write". #962

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

sunfishcode
Copy link
Contributor

This just fixes a few comments that appear to have been copied and
pasted from stdout.rs.

@sunfishcode
Copy link
Contributor Author

The CI failure is unrelated:

error: unknown `doc` attribute `unstable`
   --> src/utils.rs:145:46
    |
145 |               #[cfg_attr(feature = "docs", doc(unstable))]
    |                                                ^^^^^^^^
    | 
   ::: src/lib.rs:336:1
    |
336 | / cfg_unstable_default! {
337 | |     #[doc(inline)]
338 | |     pub use std::{write, writeln};
339 | | }
    | |_- in this macro invocation

This just fixes a few comments that appear to have been copied and
pasted from stdout.rs.
@sunfishcode
Copy link
Contributor Author

Rebased, and now the CI is green.

Copy link
Member

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is correct, though some stdin pipes can also be written to but I don't think that async-std supports that.

@Fishrock123 Fishrock123 merged commit 7560f0f into async-rs:master Jul 14, 2021
@sunfishcode sunfishcode deleted the main branch July 14, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants