server: add method for retrieving client certificates #35
Conversation
|
Is anything preventing this from getting merged? |
| @@ -21,6 +21,15 @@ pub struct TlsStream<IO> { | |||
| pub(crate) state: TlsState, | |||
| } | |||
|
|
|||
| impl<IO> TlsStream<IO> { | |||
| pub fn peer_certificates(&self) -> Option<Vec<Vec<u8>>> { | |||
There was a problem hiding this comment.
Change this to return the Certificates either directly or by reference.
There was a problem hiding this comment.
There was already a pull request for returning the certificates directly ( #25 ) which was rejected in part because @skade didn't want to expose rustls. I think he has a point. A rustls certificate is just a Vec anyway.
Regarding references. I guess we could consider returning an iterator over &Vec here if you want to avoid copying the whole vector by default.
The commit adding documentation by @nacardin in #39 should be added though.
|
Similar to #33, I'm not interested in a design that exposes the client certificate raw. I know I'm away from this goal, as I was sidelined, which is the reason why I put a maintenance notice out, showing a path to a structured handover to new maintainers. It's important to me though that the above design is taken over along with it. |
Fixes #33