Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial release #10

Merged
merged 3 commits into from
Jan 12, 2022
Merged

feat: initial release #10

merged 3 commits into from
Jan 12, 2022

Conversation

dan-r
Copy link
Member

@dan-r dan-r commented Jan 12, 2022

Time to release to NPM!

This reflects changes requested by @derberg in #3 and also concludes #2.

@lewis-relph as far as I can see we don't need these hooks anymore?

@dan-r dan-r requested review from dalelane and lewis-relph January 12, 2022 12:54
@derberg
Copy link
Member

derberg commented Jan 12, 2022

just for the context - this hook basically gives you this additional parameter https://github.com/asyncapi/java-template/blob/master/package.json#L66

it enables your template to work in the way that when someone generates your code, the asyncapi file used for generation will also end up in generated output and with this flag you can also decide where exactly.

so you either remove flag and dependencies and config, or just document the flag in the readme

@dan-r
Copy link
Member Author

dan-r commented Jan 12, 2022

Thanks for the explanation @derberg.
For this PR I think I'll go for the documentation approach!

Copy link
Collaborator

@lewis-relph lewis-relph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, glad we're keeping hooks. Bring on NPM! 👍

Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dan-r dan-r merged commit 3cea6cf into asyncapi:master Jan 12, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dan-r dan-r deleted the release-changes branch January 12, 2022 13:42
@derberg
Copy link
Member

derberg commented Jan 12, 2022

Congrats!!! https://twitter.com/AsyncAPISpec/status/1481256282103238660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants