-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial release #10
Conversation
just for the context - this hook basically gives you this additional parameter https://github.com/asyncapi/java-template/blob/master/package.json#L66 it enables your template to work in the way that when someone generates your code, the asyncapi file used for generation will also end up in generated output and with this flag you can also decide where exactly. so you either remove flag and dependencies and config, or just document the flag in the readme |
Thanks for the explanation @derberg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, glad we're keeping hooks. Bring on NPM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 0.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Time to release to NPM!
This reflects changes requested by @derberg in #3 and also concludes #2.
@lewis-relph as far as I can see we don't need these hooks anymore?