Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist/bundle.js from the repo #530

Closed
derberg opened this issue Apr 20, 2022 · 1 comment · Fixed by #556
Closed

Remove dist/bundle.js from the repo #530

derberg opened this issue Apr 20, 2022 · 1 comment · Fixed by #556
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Apr 20, 2022

Reason/Context

dist/bundle.js was always there in the repo, but then we added release automation and it anyway is always available, fresh and nice on the release level, example: https://github.com/asyncapi/parser-js/releases/tag/v1.14.1

In other words: bundle.js is already available on a release level + npm package.

Having it in the repo only causes confusion and continuous issues:

  • with every single contribution as people commit it, then they have to remove it and it is causing headaches
  • with long-living release branches that take months to release and in meantime bundle.js on master gets updated

What do you think?

cc @jonaslagoni @fmvilas @magicmatatjahu

Description

We need to:

  • remove bundle.js from this repo
  • update readme information that bundle.js is also available on a release level
  • add bundle.js to .gitignore
  • update package.json to make sure bundle.js is an exception and that even though it is ignored, it should be pushed to npm
@derberg derberg added the enhancement New feature or request label Apr 20, 2022
@magicmatatjahu
Copy link
Member

Let's remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants