Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove bundle.js from repository #556

Merged
merged 3 commits into from
May 25, 2022
Merged

refactor: remove bundle.js from repository #556

merged 3 commits into from
May 25, 2022

Conversation

derberg
Copy link
Member

@derberg derberg commented May 25, 2022

Description

  • bundle.js no longer part of repo and git ignored
  • added specific configuration what should be included in package after publishing (including bundle generated during release) - I validated locally with npm pack
  • readme explains that we also put bundle on release

Related issue(s)
Resolves #530

derberg
derberg commented May 25, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
magicmatatjahu
magicmatatjahu previously approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@derberg derberg requested a review from magicmatatjahu May 25, 2022 11:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member Author

derberg commented May 25, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 1464ba8 into asyncapi:master May 25, 2022
@derberg derberg deleted the removebundle branch May 25, 2022 14:03
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dist/bundle.js from the repo
3 participants
@derberg @asyncapi-bot @magicmatatjahu