-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow servers and channels to be fetched from components #430
Merged
asyncapi-bot
merged 11 commits into
asyncapi:2022-01-release
from
smoya:feat/serversChannelsAsComponents
Jan 13, 2022
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
293129c
feat: allow servers and channels to be defined as components
smoya 5bae790
allServers() and allChannels() at doc level
smoya 93c4e67
handle servers collision
smoya fbdcc83
handle channels collision
smoya 6e481bd
drop allChannels and allServers
smoya 0d8171a
asyncapi/specs package points to 2022-02-release branch
smoya 776c950
revert bundle.js
smoya 37686f4
revert bundle.js
smoya a6ca9ff
asyncapi/specs package points to 2022-02-release tag
smoya c508732
Merge remote-tracking branch 'origin/2022-01-release' into feat/serve…
smoya 68f9f2d
update @asyncapi/specs to v2.13.0-2022-01-release.3
smoya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fmvilas are you sure we should grab sources from github?
imho we should either pull a specific version from npm
2.13.0-2022-01-release.1
or just fix to the release candidate tag, so2022-01-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: If we use
2022-01-release
as version, it will point to the same code as latest commit in that branch? So it is the same as I added but pointing to the npm package tag instead of github branch, right? If so, I can change to it as IMHO it also makes sense as you said.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically if you point to
2022-01-release
and you donpm install
then@asyncapi/specs
version2.13.0-2022-01-release.1
will be installed, if2
release candidate is available, then2.13.0-2022-01-release.2
will be installed.so yeah, might be that the best solution is to point to the
2022-01-release
npm tag instead of a specific version each timeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done!