Skip to content

Commit

Permalink
Avoid finding out std::basic_string_view (pytorch#1528)
Browse files Browse the repository at this point in the history
As pytorch moving to C++17, the binary can contain both "std::basic_string_view" and "std::__cxx11::basic_string<", change the pattern to avoid finding out std::basic_string_view, causing false positives.
  • Loading branch information
cyyever authored Dec 27, 2023
1 parent b9d2b93 commit 770c827
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion check_binary.sh
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ if [[ "$(uname)" != 'Darwin' ]]; then
#
# To check whether it is using cxx11 ABI, check non-existence of symbol:
PRE_CXX11_SYMBOLS=(
"std::basic_string"
"std::basic_string<"
"std::list"
)
# To check whether it is using pre-cxx11 ABI, check non-existence of symbol:
Expand Down

0 comments on commit 770c827

Please sign in to comment.