Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stable containers unintentionally enable *all* govet analyzers #666

Closed
atc0005 opened this issue Jun 20, 2022 · 0 comments · Fixed by #667
Closed

stable containers unintentionally enable *all* govet analyzers #666

atc0005 opened this issue Jun 20, 2022 · 0 comments · Fixed by #667
Assignees
@atc0005
Labels
bug Something isn't working linting stable stable-build-only stable-lint-only
Milestone
v0.6.15

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 20, 2022

As part of the work to transition the stable containers from Go 1.17 to Go 1.18, I inadvertently carried over the settings from the unstable image. This image was already using Go 1.18 specific settings + some linters/analyzers I was testing.

At some point this will not be a problem, but there are some projects I'm maintaining where I'm not yet prepared to work on all identified issues. I want to focus now just on anything surfaced from a transition to Go 1.17 (or earlier) to Go 1.18. Later once Go 1.19 is out and everything is still as expected I can increase the number of validation checks performed.
@atc0005 atc0005 added this to the Next Release milestone Jun 20, 2022
@atc0005 atc0005 self-assigned this Jun 20, 2022
@atc0005 atc0005 changed the title stable containers unintentionally enabled *all* govet analyzers stable containers unintentionally enable *all* govet analyzers Jun 20, 2022
atc0005 added a commit that referenced this issue Jun 20, 2022
@atc0005
Disable explicit enabling of all govet anaylzers
0b4f20d 
- remove comment block denoting the `stable` image golangci-lint
  config file as belonging to the `unstable` image
- comment out setting that enables *all* `govet` analyzers by
  default and leave breadcrumb pointing back to the related
  GH issue for further review

refs GH-666
@atc0005 atc0005 mentioned this issue Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting stable stable-build-only stable-lint-only
Projects
None yet
Milestone
v0.6.15
Development

Successfully merging a pull request may close this issue.

Disable explicit enabling of all govet anaylzers atc0005/go-ci
1 participant
@atc0005