Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-undef-class :global bug #82

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix no-undef-class :global bug #82

merged 2 commits into from
Sep 19, 2023

Conversation

yuhsianw
Copy link
Collaborator

@yuhsianw yuhsianw commented Sep 12, 2023

Fixes false positive on :global in the no-undef-class rule #14

<!-- Fails with undefined `localClass` -->
<div class="localClass">
  ...
</div>
/** Whole selector is removed due to `global:` **/
.localClass global: .globalClass {...}

Fixed by only removing the global classes after :global and inside :global(...)

@yuhsianw yuhsianw changed the title Fix no-undef-class global: bug Fix no-undef-class :global bug Sep 12, 2023
@yuhsianw yuhsianw merged commit fb59802 into atfzl:master Sep 19, 2023
@yuhsianw yuhsianw deleted the frankwang/fix-no-undef-class-global-bug branch September 19, 2023 04:04
@yuhsianw yuhsianw linked an issue Sep 19, 2023 that may be closed by this pull request
@lgenzelis
Copy link

Probably not the right place to ask this, but Idk which place would that be. Does this merge mean that the repo found itself a new maintainer? 🤩🤩

@yuhsianw
Copy link
Collaborator Author

Hi @lgenzelis, yes this repo is now being maintained. More updates are coming shortly. Stay tuned 😉

If you have any questions, feel free to open up an issue or shot me an email ([email protected]). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-undef-class with :global
4 participants