Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

[WIP] PDFHandler accepts file like objects #189

Closed
wants to merge 1 commit into from
Closed

[WIP] PDFHandler accepts file like objects #189

wants to merge 1 commit into from

Conversation

pqrth
Copy link
Contributor

@pqrth pqrth commented Nov 1, 2018

Closes #91

@vinayak-mehta
Copy link
Contributor

Closing in favor of #236.

@pqrth pqrth deleted the read-pdf-url branch April 18, 2019 13:57
@pilotjoe
Copy link

pilotjoe commented Oct 8, 2020

Closing in favor of #236.

@vinayak-mehta If I understand correctly, #236 only resolves reading from a URL but not reading a file like object. I have run across situations where it would be very useful to read from a file like object. For example, reading PDFs from SharePoint where authentication from requests is needed, an HTTP 401 Unauthorized error would be produced just passing the URL to read_pdf(). It appears the only way to currently handle these cases is to pull the PDF using another library such as requests, save the file locally, pull the file back in using read_pdf(), then deal with the housekeeping of written files (or use something like tempfile as mentioned in #158). This is less efficient than having read_pdf() read directly from a file like object.

@pilotjoe
Copy link

pilotjoe commented Oct 8, 2020

For anyone running across this, it appears #376 will be addressing this. It is also discussed in camelot-dev/camelot#103

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_pdf from a URL
3 participants