Fix domain sharding for ESM output #292
Merged
+106
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems there was another code path I was not aware of that can generate URLs that needs to be sharded.
When outputting to ESM, the runtime imports
esm-js-loaderand calls its load function with the public ID we're after.To avoid things becoming entirely too messy, I've created a new
esm-js-loader-shardsthat will call the sharding helper on the URL generated, before passing it toimport.Adding a test for this required updating the
runintegration test helper so that it could handle sharded domains (because it was trying to request assets fromintegration/dist-4/a.hash.js).