Fix unused symbols for dependencies without symbols #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshdavid
approved these changes
Dec 24, 2024
| let symbols = nullthrows(this.bundleGraph.getUsedSymbols(d)); | ||
| let symbols = this.bundleGraph.getUsedSymbols(d); | ||
|
|
||
| // No used symbols avaiable for the asset, make sure we keep all of them |
There was a problem hiding this comment.
My spell checker stopped working and I'm instantly pushing typos 😅
JakeLane
force-pushed
the
fix-used-symbols-check-scope-hoisting
branch
from
bae4b67 to
cc79d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
From the issue found by @alshdavid. simple fix to avoid errors and deoptimise if the bundle doesn't support symbols.
Changes
When a dependency doesn't have symbols, don't error but just deoptimise instead.
Checklist