[WIP] Global component #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsdouges
force-pushed
the
global-component
branch
from
576f513 to
ad18fd2
Compare
Noice..btw renovate PR's almost crashed my inbox..damn so many mails 😅 |
pgmanutd
reviewed
Dec 24, 2020
packages/react/src/global/index.tsx
Outdated
| import { createSetupError } from '../utils/error'; | ||
|
|
||
| interface GlobalProps { | ||
| style: CssFunction | CssFunction[]; |
There was a problem hiding this comment.
🤔 Should we use style or something else? It might confuse consumers because react in built components accept style prop which translates to inline styles.
Emotion also uses styles instead of style. Should we use that or something else 🤔?
Not sure 😅
There was a problem hiding this comment.
Ah definitely 😄 should have been styles
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be tinkering with this over the holidays. Chime in if you're interested.