fix type clash between mocha and jest #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
reviewed
Apr 8, 2020
tsconfig.json
Outdated
| @@ -10,7 +10,8 @@ | |||
| "forceConsistentCasingInFileNames": true, | |||
| "removeComments": true, | |||
| "esModuleInterop": true, | |||
| "allowSyntheticDefaultImports": true | |||
| "allowSyntheticDefaultImports": true, | |||
| "types": ["jest"] | |||
There was a problem hiding this comment.
will this exclude every other library?
There was a problem hiding this comment.
This will exclude every other @type/* listed in package.json.
Alternatively we could list all type defs here or enable skipLibCheck which does the same thing as types: [] 😕
There was a problem hiding this comment.
to be more clear, something like:
- "types": ["jest"],
+ "types": ["gzip-js", "jest", "react", "react-dom"],Might be ideal, but would require every typedef to be listed here manually 😢
danieldelcore
force-pushed
the
cypress-ts-config
branch
2 times, most recently
from
0b28e35 to
c86a8a4
Compare
danieldelcore
force-pushed
the
cypress-ts-config
branch
from
c86a8a4 to
08666e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a type clash between
mochaandjest.Both libraries share the same globals which clash: Thread
There appears to be a fix in the develop branch of Cypress which is currently unavailable.
There are two possible workarounds. The one i've provided narrows down the types and the alternate approach is to enable
skipLibCheckswhich is less than ideal.Related issues: