Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AXON-41] chore: fix stack limit and webview name strings #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[AXON-41] chore: fix stack limit and webview name strings #64

wants to merge 1 commit into from

Conversation

sdzh-atlassian
Copy link
Member

What is this?

Small follow-up from the previous AXON-41 PRs:

  • Limit for the number of characters in the shortened stack: 150 -> 1500
  • Renamed the values of the enum for page names that show up in analytics events

Also - introduced some nomenclature for the different "legacy" page implementations, lol :D

Whatever new thing we build will be v3 in these terms 😉

How was this tested?

Only the basic build tests, didn't do any special testing since this is a small change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwieger-atlassian-com bwieger-atlassian-com bwieger-atlassian-com approved these changes

@cabella-dot cabella-dot Awaiting requested review from cabella-dot cabella-dot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdzh-atlassian @bwieger-atlassian-com