Updated pod labels for all products #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmybchopps
requested review from
nanux,
yzha645 and
bianchi2
as code owners
|
@bianchi2 Anything else I need to do for this PR? I noticed it had a checkbox for adding unit tests, but it doesn't seem like that applies for the changes made in this specific instance. |
|
I believe the expected output tests will need to be updated to reflect the fact the labels are now included. |
bianchi2
approved these changes
Nov 7, 2024
|
@jimmybchopps I have pushed tests fixes to your fork so it looks good now. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Updated labels on all pods under stateful sets to include the same labels on their associated pod workloads. Previously, the pods only had the selector labels. With this update, all pods will have the same labels as their parent resource to improve traceability. Validated the common labels include the selector labels as well so this will only result in a few more labels being added that were previously missing from the associated pod resources.
Checklist
e2elabel)