Add nodeId and requestId to performance entries #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczuj
reviewed
Nov 8, 2023
src/main/kotlin/com/atlassian/performance/tools/jiraactions/w3c/harvesters/JsResources.kt
Outdated
Show resolved
Hide resolved
mgrzaslewicz
force-pushed
the
issue/jperf-1409-add-nodeid-requestid
branch
from
08ee61c to
d0f8828
Compare
pczuj
reviewed
Nov 8, 2023
...ain/kotlin/com/atlassian/performance/tools/jiraactions/api/w3c/RecordedPerformanceEntries.kt
Outdated
Show resolved
Hide resolved
pczuj
reviewed
Nov 8, 2023
src/main/kotlin/com/atlassian/performance/tools/jiraactions/w3c/harvesters/JsResources.kt
Outdated
Show resolved
Hide resolved
pczuj
reviewed
Nov 8, 2023
src/main/kotlin/com/atlassian/performance/tools/jiraactions/api/BackendTimeSlot.kt
Outdated
Show resolved
Hide resolved
mgrzaslewicz
force-pushed
the
issue/jperf-1409-add-nodeid-requestid
branch
from
d0f8828 to
cd61af9
Compare
I've found no jira log entries in JPT that contain requestId. In other words, I'm not sure if it's valuable so better skip it. It can be easily added later
mgrzaslewicz
force-pushed
the
issue/jperf-1409-add-nodeid-requestid
branch
from
cd61af9 to
f9aa00c
Compare
pczuj
reviewed
Nov 9, 2023
…ot an API contract
pczuj
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.