Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship version 10! #838

Closed
alexreardon opened this issue Sep 27, 2018 · 25 comments
Closed

Ship version 10! #838

alexreardon opened this issue Sep 27, 2018 · 25 comments

Comments

@alexreardon
Copy link
Collaborator

Lots going out in version 10, I'll use this issue as a good point to tag things going out

@alexreardon
Copy link
Collaborator Author

alexreardon commented Oct 2, 2018

We have now shipped an alpha. In order to simply support for large projects and multi-package repos, we have released the alpha under a new package name: react-beautiful-dnd-next

[email protected]

I will try to update here as new versions are released

As mentioned, the release is still alpha. So keep that in mind!

The API for currently supported use cases should remain mostly unchanged. I will be doing extensive upgrade notes as we move closer to the release

@alexreardon
Copy link
Collaborator Author

[email protected] is now out

@alexreardon
Copy link
Collaborator Author

I have a big todo list on my own trello board so i'll keep chipping away on things there.

My current thinking is that a stable release is 1-2 weeks away

@alexreardon
Copy link
Collaborator Author

[email protected] is out with a new Draggable > payload prop /cc @Frozenlock

@alexreardon
Copy link
Collaborator Author

I have taken the payload value and prop out for now pending discussion in #498

@torre76
Copy link

torre76 commented Oct 8, 2018

Hi @alexreardon, will be #484 included in this release?

@bnewcomer
Copy link

Will #511 (grouping/combining) be included? Any timeline updates?

@alexreardon
Copy link
Collaborator Author

Yes #511 is included. There are also a lot of other things that are not listed here right now

@alexreardon
Copy link
Collaborator Author

#484

@alexreardon
Copy link
Collaborator Author

10.0.0-alpha.4 is now out!

yarn add [email protected] to give it a go

@alexreardon
Copy link
Collaborator Author

Descoped: #331

Sadly we will no longer be shipping this in version 10 #838

After testing I continued to run into scenarios that would require additional sophisticated logic. They include:

  • moving to an invisible logic in a scroll container
  • moving which changes the max scroll of the window

We will look to this as a feature (minor) release post v10

@nicubarbaros
Copy link

#484

@alexreardon Is that an YES?

http://gph.is/1R12N2Z

@alexreardon
Copy link
Collaborator Author

[email protected] is now out

It contains a few minor bug fixes

@alexreardon
Copy link
Collaborator Author

@alexreardon
Copy link
Collaborator Author

Getting very close to all the tests passing:

Tests:       28 failed, 1219 passed, 1247 total

@alexreardon
Copy link
Collaborator Author

[email protected] is now out

We have moved to beta releases as the build is now passing

builds-passing

@alexreardon
Copy link
Collaborator Author

screen shot 2018-11-02 at 12 17 27 pm

I have spend 4hrs + trying to overcome a flakey test. That is now resolved 👍

@alexreardon
Copy link
Collaborator Author

alexreardon commented Nov 4, 2018

Up to now I have been working off a Trello board. I'll now move a todo list here to increase visibility:

To do list for version 10

Code

  • ensure placeholder in Droppable is hidden during recollection
  • fix x2 issues that Balaz has found
  • rename hooks to lifecycle callbacks to avoid name clashing with new react hooks
  • upgrade flow in tiny-invariant, css-box-model and memoize-one. Ensure css-box-model is on a matching version of tiny-invariant for kb savings
  • Investigate Jitter when autoscrolling to the end of a list #764
  • tests for combine screen reader messaging

Docs

  • create combining guide

  • update types

  • update screen reader guide

  • update README with latest types

  • add section about dev messaging

  • fill in tree example on dynamic guide

  • write release notes

  • improve dynamic additions docs

  • add section on IE11 and ponyfills

  • add section on fixed lists

  • no pointer events inside a droppable during a drag

  • add limitations section:

  • no margin collapsing between items

  • no negative margins on the main axis of a list

  • etc

Examples

  • add example for combine with list and board
  • dynamic additions and removals of Draggable in a foreign list

Post-release

@alexreardon
Copy link
Collaborator Author

[email protected] is now out. It features some fixes on our dynamic additions code path

@alexreardon
Copy link
Collaborator Author

[email protected] is out and contains (another) fix for #764 (it is a tricky one!)

Everything looks ready to go. I plan on shipping version 10 stable on Monday

@marvinjaworski
Copy link

Hey @alexreardon,
I need the onBeforeDragStart function you work on, it's possible in [email protected] to use this function?

And when does the feature come in react-beautiful-dnd?

@alexreardon
Copy link
Collaborator Author

This has now shipped! See version 10 release notes

@nicubarbaros
Copy link

nicubarbaros commented Nov 12, 2018

Wow, congrats @alexreardon and the team. Cannot wait to upgrade and use that sexy dynamic add/remove feature. The combine feature looks sick!

By the way, any ET for dynamic droppable? At least for adding/removing them at the begging/end of the queue.

@tjramage
Copy link

@alexreardon — you're killing it! Well done on v10, it's great. Keep it up. 😄

@alexreardon
Copy link
Collaborator Author

Thanks @tjramage! I appreciate your encouragement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants