feat/landing-5 #20

oxiqod · 2023-05-26T12:20:01Z

No description provided.

TorinAsakura

У меня всё

а это вишенкой
Warning: forwardRef render functions accept exactly two parameters: props and ref. Did you forget to use the ref parameter?

landing/fragments/landing-ticker/src/line/line.component.tsx

landing/fragments/landing-ticker/src/ticker.component.tsx

landing/fragments/landing-ticker/src/line/line.component.tsx

TorinAsakura · 2023-05-27T14:59:59Z

landing/fragments/landing-ticker/src/technology/technology.component.tsx

@@ -0,0 +1,4 @@
+export const TechnologyKit = {
+  webDevelopment: 'JavaScript,HTML,CSS,SASS,Vanilla JS,Jade',


ты издеваешься? это должен быть массив объектов, по которому можно итерироваться, завтра нам надо будет выбросить хтмл, чо, пойдёшь в код, править строку? А если опечатаешься?

@TorinAsakura
Таким образом? ссылка
не смогла найти среди проектов как выполняется запись элементов именно для бегущей строки

так не верно? ты сказал именно объекты в массиве
export const technologyKit = {
webDev: ['JavaScript','HTML','CSS','SASS','Vanilla JS','Jade'],
workspace: ['Github','Atom','Figma']
}

или

export const KitWebDev = ['JavaScript','HTML','CSS','SASS','Vanilla JS','Jade']
export const KitWorkspace = ['Github','Atom','Figma']

Что значит "не смогла найти как выполняется запись "ИМЕННО ДЛЯ БЕГУЩЕЙ СТРОКИ""?????

ui/condition/src/condition.component.tsx

TorinAsakura

И я не увидел фиксов по неймингам

TorinAsakura

в который (и последний) раз обращу твоё внимание на "некоторые" элементы требующие сверки с фигмой…

ui/condition/src/condition.interface.ts

ui/condition/src/some-animations/some-animations.component.ts

oxiqod · 2023-05-30T07:51:03Z

@TorinAsakura

в который (и последний) раз обращу твоё внимание на "некоторые" элементы требующие сверки с фигмой…

речь же о кнопке курсы из мобильной версии (перенос слова)?
или у тебя не отображается еще и вложенная в нее иконка?

TorinAsakura · 2023-05-30T07:52:15Z

@oksssvv На скриншот смотри

oxiqod · 2023-05-30T08:00:13Z

@TorinAsakura

На скриншоте смотри

Судя по скрину - иконка не отображается, а другие кнопки в которых есть вложение иконки? Которые ниже
У меня просто все на месте, мне нужно понять что не так, что бы исправить

TorinAsakura · 2023-05-30T08:00:41Z

@oksssvv у меня вопрос только к тому, что на скрине

TorinAsakura

Warning: Received true for a non-boolean attribute fill.

If you want to write it to the DOM, pass a string instead: fill="true" or fill={value.toString()}.
at button
at /Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/@emotion-react-virtual-b301de22a9/4/.yarn/berry/cache/@emotion-react-npm-11.11.0-fda75c579c-9.zip/node_modules/@emotion/react/dist/emotion-element-48d2c2e4.cjs.dev.js:70:25
at eval (webpack-internal:///../../../../.yarn/virtual/@ui-button-virtual-6366d4c56c/1/ui/button/src/button.component.tsx:36:83)
at div
at /Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/@emotion-react-virtual-b301de22a9/4/.yarn/berry/cache/@emotion-react-npm-11.11.0-fda75c579c-9.zip/node_modules/@emotion/react/dist/emotion-element-48d2c2e4.cjs.dev.js:70:25
at div
at /Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/@emotion-react-virtual-b301de22a9/4/.yarn/berry/cache/@emotion-react-npm-11.11.0-fda75c579c-9.zip/node_modules/@emotion/react/dist/emotion-element-48d2c2e4.cjs.dev.js:70:25
at div
at /Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/@emotion-react-virtual-b301de22a9/4/.yarn/berry/cache/@emotion-react-npm-11.11.0-fda75c579c-9.zip/node_modules/@emotion/react/dist/emotion-element-48d2c2e4.cjs.dev.js:70:25
at Navigation (webpack-internal:///../../../../.yarn/virtual/@landing-navigation-fragment-virtual-f1fc73f6a4/1/landing/fragments/landing-navigation/src/navigation.component.tsx:37:69)
at div
at /Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/@emotion-react-virtual-b301de22a9/4/.yarn/berry/cache/@emotion-react-npm-11.11.0-fda75c579c-9.zip/node_modules/@emotion/react/dist/emotion-element-48d2c2e4.cjs.dev.js:70:25
at IndexPage
at ThemeProvider (/Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/@emotion-react-virtual-b301de22a9/4/.yarn/berry/cache/@emotion-react-npm-11.11.0-fda75c579c-9.zip/node_modules/@emotion/react/dist/emotion-element-48d2c2e4.cjs.dev.js:125:32)
at ThemeProvider (webpack-internal:///../../../../.yarn/virtual/@ui-theme-virtual-8835c06af0/1/ui/theme/src/theme.provider.tsx:20:26)
at IntlProvider (/Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/react-intl-virtual-694b2aa2d7/4/.yarn/berry/cache/react-intl-npm-6.4.2-0718017b10-9.zip/node_modules/react-intl/src/components/provider.js:88:47)
at App (webpack-internal:///./pages/_app.tsx:22:16)
at StyleRegistry (/Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/styled-jsx-virtual-51128919e0/4/.yarn/berry/cache/styled-jsx-npm-5.0.7-d47abf001f-9.zip/node_modules/styled-jsx/dist/index/index.js:448:36)
at AppContainer (/Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/next-virtual-919027c60d/4/.yarn/berry/cache/next-npm-12.3.4-cdaf2db0a7-9.zip/node_modules/next/dist/server/render.js:298:29)
at AppContainerWithIsomorphicFiberStructure (/Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/next-virtual-919027c60d/4/.yarn/berry/cache/next-npm-12.3.4-cdaf2db0a7-9.zip/node_modules/next/dist/server/render.js:327:57)
at div
at Body (/Users/torinasakura/workspace/academy/oksssvv.github.io/.yarn/virtual/next-virtual-919027c60d/4/.yarn/berry/cache/next-npm-12.3.4-cdaf2db0a7-9.zip/node_modules/next/dist/server/render.js:614:21)

Что ты там с этой кнопкой несчастной столько времени возишься Оксан?

2023-06-01.21.55.36.mov

TorinAsakura

Полагаю, на 6-м степе мы с тобой обсудим вопросы адаптивности, так как это конечно же катастрофа, ну, с учётом количества примеров, которые у тебя есть под рукой

feat: create ticker-fragment for desktop and mobile

acf97bb

oxiqod self-assigned this May 26, 2023

oxiqod linked an issue May 26, 2023 that may be closed by this pull request

Academy landing, step 5 #19

Closed

oxiqod changed the title ~~feat: landing-5~~ feat/landing-5 May 26, 2023

oxiqod requested a review from TorinAsakura May 26, 2023 12:53

TorinAsakura suggested changes May 26, 2023

View reviewed changes

landing/fragments/landing-ticker/src/line/line.component.tsx Outdated Show resolved Hide resolved

landing/fragments/landing-ticker/src/ticker.component.tsx Outdated Show resolved Hide resolved

fix: add ref for button and technology component

25acc20

oxiqod requested a review from TorinAsakura May 27, 2023 10:58

TorinAsakura suggested changes May 27, 2023

View reviewed changes

fix: add adaptability for UHD

49f5eaf

TorinAsakura suggested changes May 27, 2023

View reviewed changes

fix: add sphere and fix button for adaptability

046bdc1

TorinAsakura suggested changes May 28, 2023

View reviewed changes

ui/condition/src/condition.interface.ts Outdated Show resolved Hide resolved

ui/condition/src/some-animations/some-animations.component.ts Outdated Show resolved Hide resolved

fix: mobile button in navigation, rename some-animation

440c72e

oxiqod requested a review from TorinAsakura May 30, 2023 08:04

TorinAsakura suggested changes Jun 1, 2023

View reviewed changes

fix: add key for technology, fix button courses and rename buttonfill

c0a8d18

oxiqod requested a review from TorinAsakura June 2, 2023 08:53

TorinAsakura approved these changes Jun 2, 2023

View reviewed changes

TorinAsakura merged commit b00cec6 into master Jun 2, 2023

TorinAsakura deleted the feat/landing-5 branch June 2, 2023 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/landing-5 #20

feat/landing-5 #20

oxiqod commented May 26, 2023

TorinAsakura left a comment

TorinAsakura May 27, 2023

oxiqod May 28, 2023 •

edited

Loading

TorinAsakura Jun 1, 2023

TorinAsakura left a comment

TorinAsakura left a comment

oxiqod commented May 30, 2023

TorinAsakura commented May 30, 2023

oxiqod commented May 30, 2023

TorinAsakura commented May 30, 2023

TorinAsakura left a comment

TorinAsakura left a comment

		@@ -0,0 +1,4 @@
		export const TechnologyKit = {
		webDevelopment: 'JavaScript,HTML,CSS,SASS,Vanilla JS,Jade',

feat/landing-5 #20

feat/landing-5 #20

Conversation

oxiqod commented May 26, 2023

TorinAsakura left a comment

Choose a reason for hiding this comment

TorinAsakura May 27, 2023

Choose a reason for hiding this comment

oxiqod May 28, 2023 • edited Loading

Choose a reason for hiding this comment

TorinAsakura Jun 1, 2023

Choose a reason for hiding this comment

TorinAsakura left a comment

Choose a reason for hiding this comment

TorinAsakura left a comment

Choose a reason for hiding this comment

oxiqod commented May 30, 2023

TorinAsakura commented May 30, 2023

oxiqod commented May 30, 2023

TorinAsakura commented May 30, 2023

TorinAsakura left a comment

Choose a reason for hiding this comment

TorinAsakura left a comment

Choose a reason for hiding this comment

oxiqod May 28, 2023 •

edited

Loading