Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return a Disposable from consumeDefinitionsService #47

Merged
merged 1 commit into from
Jul 22, 2021
+3 −2
Merged

fix: return a Disposable from consumeDefinitionsService #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ You can also search for [packages](https://atom.io/packages/search?q=IDE) in Ato
![image](https://user-images.githubusercontent.com/16418197/109838982-48eee680-7c0c-11eb-88ee-5ab7889bb2af.png)
![image](https://user-images.githubusercontent.com/16418197/109838990-4a201380-7c0c-11eb-9bf2-7d3bf47ade5d.png)


## Contributing
Comment on lines 32 to 33
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was also modified by npm run format.


Please see the [contributing guidelines](CONTRIBUTING.md).
4 changes: 3 additions & 1 deletion lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ export function deactivate() {
}

export function consumeDefinitionsService(provider) {
providerRegistry.addProvider(provider)
const providerDisposable = providerRegistry.addProvider(provider)
subscriptions.add(providerDisposable)
return providerDisposable
}

export function getClickProvider() {
Expand Down